Regression in 3.21.2: pattern matching for instanceof crashes with AsSuperVisitor: type is not an erased subtype of supertype

[eikemeier]

Example repository at https://github.com/eikemeier/checker-framework-jdk17

  public boolean equals(@Nullable Object o) {
    return o == this
        || o instanceof Greeting that
        && Objects.equals(name, that.name);
  }

crashes on JDK17 with version 3.21.2:

error: AsSuperVisitor: type is not an erased subtype of supertype.
  type: Object
  superType: Greeting
  ; The Checker Framework crashed.  Please report the crash.
  Compilation unit: src/main/java/com/example/hello_world/Greeting.java
  Last visited tree at line 21 column 12:
          || o instanceof Greeting that
  Exception: java.lang.Throwable; java.lang.Throwable
          at org.checkerframework.javacutil.BugInCF.<init>(BugInCF.java:34)
          at org.checkerframework.framework.type.AsSuperVisitor.errorTypeNotErasedSubtypeOfSuperType(AsSuperVisitor.java:145)
          at org.checkerframework.framework.type.AsSuperVisitor.visitDeclared_Declared(AsSuperVisitor.java:333)
          at org.checkerframework.framework.type.AsSuperVisitor.visitDeclared_Declared(AsSuperVisitor.java:29)
          at org.checkerframework.framework.util.AtmCombo.accept(AtmCombo.java:311)
          at org.checkerframework.framework.type.visitor.AbstractAtmComboVisitor.visit(AbstractAtmComboVisitor.java:65)
          at org.checkerframework.framework.type.AsSuperVisitor.visit(AsSuperVisitor.java:98)
          at org.checkerframework.framework.type.AsSuperVisitor.asSuper(AsSuperVisitor.java:80)
          at org.checkerframework.framework.util.AnnotatedTypes.asSuper(AnnotatedTypes.java:113)
          at org.checkerframework.framework.util.AnnotatedTypes.castedAsSuper(AnnotatedTypes.java:141)
          at org.checkerframework.framework.type.DefaultTypeHierarchy.visitTypeArgs(DefaultTypeHierarchy.java:476)
          at org.checkerframework.framework.type.DefaultTypeHierarchy.visitDeclared_Declared(DefaultTypeHierarchy.java:448)
          at org.checkerframework.framework.type.DefaultTypeHierarchy.visitDeclared_Declared(DefaultTypeHierarchy.java:45)
          at org.checkerframework.framework.util.AtmCombo.accept(AtmCombo.java:311)
          at org.checkerframework.framework.type.DefaultTypeHierarchy.isSubtype(DefaultTypeHierarchy.java:155)
          at org.checkerframework.checker.nullness.KeyForAnnotatedTypeFactory$KeyForTypeHierarchy.isSubtype(KeyForAnnotatedTypeFactory.java:152)
          at org.checkerframework.framework.type.DefaultTypeHierarchy.isSubtype(DefaultTypeHierarchy.java:131)
          at org.checkerframework.common.basetype.BaseTypeVisitor.visitInstanceOf(BaseTypeVisitor.java:2395)
          at org.checkerframework.common.basetype.BaseTypeVisitor.visitInstanceOf(BaseTypeVisitor.java:180)

The program compiles with version 3.21.1. Tested on macOS and Linux.