More precise math font autocomplete suggestions #6316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to detect a `math.equation` show-set rule via the AST rather than by heuristics, and determine if a font is a math font based on the presence of a MATH table rather than the family name.
|
Refactored the detection of show rules to be a bit more flexible (e.g when show rule body is more deeply nested, rather than just a show-set rule). It feels less... arbitrary like this. |
IgKh
force-pushed
the
math-font-autocomplete
branch
from
1440979 to
58e6407
Compare
|
Thank you, looks very clean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stab at fixing #2732.
Try to detect a
math.equationshow-set rule via the AST rather than by heuristics, and determine if a font is a math font based on the presence of a MATH table rather than the family name.