-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssl error accessing yahoo finance #18
Comments
@hlandgar, Any more details? I installed 1.1.8 and ran the same query in irb successfully. |
Seeing the same error both locally and on heroku. Started yesterday. Just check again and it is working. Yahoo must have has a temporary certificate issue that they fixed overnight. BTW, nice gem. Best, Harris Harris Landgarten ----- Original Message ----- @hlandgar, Any more details? I installed 1.1.8 and ran the same query in irb successfully. Reply to this email directly or view it on GitHub: |
Glad it's sorted! |
I'm still getting the same error :/ I think it's a problem in yahoo's side. Is there a way to disable the SSL verification? Chrome marks this as unsafe: https://query.yahooapis.com/v1/public/yql |
Issue back for me too. Could be yahoo does certificate maintenance of some kind but you should take a look. Harris Landgarten ----- Original Message ----- I'm still getting the same error :/ Reply to this email directly or view it on GitHub: |
Odd. Just checked again, and everything is working fine for me. Maybe it is a regional issue? @hlandgar, @dcu, Are you able to make a query to yahooapis.com directly? |
I just checked and it is working again for me. Either yahoo is screwing around with certificates or maybe some of their servers have good certs and some not. It seems to be a yahoo issue in any case but not regional. You might want optionally trap this error and see if the data is good. Harris Landgarten ----- Original Message ----- Odd. Just checked again, and everything is working fine for me. Maybe it is a regional issue? @hlandgar, @dcu, Are you able to make a query to yahooapis.com directly? Reply to this email directly or view it on GitHub: |
In the meantime this hack worked for me:
NOTE: it'll print a lot of warning messages saying it is unsafe |
When querying yahoo from chrome I get this ssl error:
|
@dcu, @hlandgar, thanks for the additional info. Unfortunately, I don't think there is much I can do. Unfortunately, I can't recreate the issue, and if I could, it appears to be a DNS/SSL issue with yahoo. The gem test suite uses VCR, so we could in fact capture the response. We would at least be able to confirm the response is invalid. You'd need to:
Just one of those VCR cassettes would allow me to debug the problem, and see if there was anything I can do. EDIT: With that being said, if you can't even open this url in a browser then the cassette isn't going to be much different. If you are using this gem in production, you might want to take a look at this gem: |
Scratch that. There is something we can do. We just need to tell RestClient not verify the SSL cert. @dcu, @hlandgar, Can one of you confirm the fix in this branch, fix/verify_ssl, works? In rails, in your GEMFILE:
Then bundle install. If this fixes the issue, I'll merge it in and do a version bump. |
It wasn't working but is now with the git fix so you most likely fixed it. And you didn't break anything. Harris Harris Landgarten ----- Original Message ----- Scratch that. There is something we can do. We just need to tell RestClient not verify the SSL cert. @dcu, @hlandgar, Can one of you confirm the fix in this branch, fix/verify_ssl, works? In rails, in your GEMFILE:
Then bundle install. If this fixes the issue, I'll merge it in and do a version bump. Reply to this email directly or view it on GitHub: |
On further checking 1.18 is getting ssl errors on heroku but my local install with the git fix is working fine. Harris Harris Landgarten ----- Original Message ----- It wasn't working but is now with the git fix so you most likely fixed it. And you didn't break anything. Harris Harris Landgarten ----- Original Message ----- Scratch that. There is something we can do. We just need to tell RestClient not verify the SSL cert. @dcu, @hlandgar, Can one of you confirm the fix in this branch, fix/verify_ssl, works? In rails, in your GEMFILE:
Then bundle install. If this fixes the issue, I'll merge it in and do a version bump. Reply to this email directly or view it on GitHub: |
[1] pry(main)> StockQuote::Stock.quote("aapl")
OpenSSL::SSL::SSLError: hostname "query.yahooapis.com" does not match the server certificate
from /home/hlandgar/.rvm/rubies/ruby-2.1.4/lib/ruby/2.1.0/openssl/ssl.rb:178:in `post_connection_check
The text was updated successfully, but these errors were encountered: