Skip to content

Commit

Permalink
generate the action header files first
Browse files Browse the repository at this point in the history
  • Loading branch information
@tyuownu
tyuownu committed Mar 13, 2020
1 parent f714c73 commit 58e0813
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions micvision/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -162,15 +162,15 @@ add_executable(${PROJECT_NAME}_exploration_client
## add_executable(localization_client src/localization_client.cpp)
add_executable(${PROJECT_NAME}_patroller src/patroller.cpp)

add_dependencies(${PROJECT_NAME}_localization
add_dependencies(${PROJECT_NAME}_localization ${PROJECT_NAME}_generate_messages_cpp
${catkin_EXPORTED_TARGETS})
add_dependencies(${PROJECT_NAME}_localization_node
add_dependencies(${PROJECT_NAME}_localization_node ${PROJECT_NAME}_generate_messages_cpp
${catkin_EXPORTED_TARGETS})
add_dependencies(${PROJECT_NAME}_exploration
add_dependencies(${PROJECT_NAME}_exploration ${PROJECT_NAME}_generate_messages_cpp
${catkin_EXPORTED_TARGETS})
add_dependencies(${PROJECT_NAME}_exploration_node
add_dependencies(${PROJECT_NAME}_exploration_node ${PROJECT_NAME}_generate_messages_cpp
${catkin_EXPORTED_TARGETS})
add_dependencies(${PROJECT_NAME}_exploration_client
add_dependencies(${PROJECT_NAME}_exploration_client ${PROJECT_NAME}_generate_messages_cpp
${catkin_EXPORTED_TARGETS})
## add_dependencies(localization_client ${catkin_EXPORTED_TARGETS})

Expand Down

2 comments on commit 58e0813

@loxxy
Copy link
Contributor

@loxxy loxxy commented on 58e0813 Mar 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same at first, but this would only solve the problem partially. It would break not finding config files (eg - LocalizationConfig.h)
${${PROJECT_NAME}_EXPORTED_TARGETS} as in my Pull Request (#11) takes care of both.

@tyuownu
Copy link
Owner Author

@tyuownu tyuownu commented on 58e0813 Mar 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same at first, but this would only solve the problem partially. It would break not finding config files (eg - LocalizationConfig.h)
${${PROJECT_NAME}_EXPORTED_TARGETS} as in my Pull Request (#11) takes care of both.

Thanks, loxxy. I know what your mean. I did not notice that difference between this two methods. Maybe the ${${PROJECT_NAME}_EXPORTED_TARGETS} is the way the write the dependencies.
I found this post, thanks a lot.

Please sign in to comment.