Conflict with Multiple File Upload field

[Avakulenko]

Gravity Forms: Multiple Form Instances version: 1.1.1
Wordpress version: 4.6.1

Plugin prevents "delete file" event in the Multiple File Upload field.

[rrobinpro]

I have same problem with Multiple Form Instances version 1.1.1 and Wordpress version 4.6.1

[medfreeman]

You can solve this by adding the following snippet in your theme's functions.php file:

if ( ! function_exists( 'gform_multiple_upload_delete_file_fix' ) ) {
	function gform_multiple_upload_delete_file_fix( $strings ) {
		if ( isset( $strings['\'gf_2\''] ) ) {
			$form_id = str_replace ( 'gf_', '', $strings['\'gf_2\'']);
			$form_id = str_replace ( '\'', '', $form_id);
			$form_id = absint( $form_id );
			if ( $form_id ) {
				$strings["onclick='gformDeleteUploadedFile(2"] = "onclick='gformDeleteUploadedFile(" . $form_id;
				$strings["onkeypress='gformDeleteUploadedFile(2"] = "onkeypress='gformDeleteUploadedFile(" . $form_id;
			}
		}
		return $strings;
	}
}

add_filter( 'gform_multiple_instances_strings', 'gform_multiple_upload_delete_file_fix' );

As you can see, my example only covers form with ID 2.
This plugin's filter 'gform_multiple_instances_strings' should obviously pass the original form id and the new random form id, so these string manipulations are not needed.

I'll try to make a few pull requests when i got more time, one to extend the filter parameters, and the second to simply add the needed string for file uploads deletion in https://github.com/tyxla/Gravity-Forms-Multiple-Form-Instances/blob/master/gravityforms-multiple-form-instances.php

[rrobinpro]

Thanks medfreeman

Your code is correct when you reload the form but not live when you upload a document.

[medfreeman]

Update that works with multifile uploads:

REMOVED CODE

And you'll also need this javascript snippet somewhere:

REMOVED CODE

edit: i have this functionality working on this branch of my fork, i'll submit this as a pull request when the previous PR are merged, and if the employed method is the best we can come up with, since it needs using a modified copy of a gravity forms javascript file.

[tyxla]

@medfreeman thank you for this! Would you like to contribute it as a PR so we can fix that in the next version?

[medfreeman]

Thanks.
I'll gladly submit a PR, but it seems i've spoken too fast.
This code results in the form not submitting the uploaded file at all.
I'm looking into it, and i'll correct the code when it's done.

[medfreeman]

I'm afraid the approach i used is the best i can come up with.
This implies having a part of a gravityforms js file in the source, with little modifications.
I'm not thrilled with it, as it could need maintenance (and could create incompatibilities with specific gravityforms versions), but the way gravity is coded now doesn't allow a better approach (do not hesitate to correct me if i'm wrong !).

[medfreeman]

I just figured that i can do this in a simpler way.
Hook on plupload 'beforeUpload' event, change multipart_params form_id to the original form id by taking the id stored in the field named 'gform_wrapper_original_id_'
That should work and only require a few lines of code, and nothing from gravity's source.
I'll close the actual PR and try to submit a new one this afternoon.

[tyxla]

@medfreeman that would be really awesome. I'm reluctant to introduce an entire file from a premium plugin in an OSS repo :) Thank you!

[medfreeman]

done!

[medfreeman]

there's a few spacing problems, i added the fix to the pr.

[tyxla]

Thanks @medfreeman, I appreciate your contribution! I'll have a look in the next few days.

[medfreeman]

Hey, what do you think of my PR ?
Thanks

[tyxla]

Hey @medfreeman, thanks for your PR!

To be honest, I'm not anxious to introduce external JS files into the plugin, especially if they include functions from the original plugin. That wouldn't be a problem if Gravity Forms were open source, but unfortunately that's not the case.

[medfreeman]

Gravity Forms is indeed opensource, GPL-3.0.
And this is about a single function.
I can add the missing credits if you'll reconsider this.
Thanks

[tyxla]

@medfreeman good call, I didn't expect for them to be GPL while being a premium plugin.
But it makes sense to use the code freely in that case, but indeed, let's add credits accordingly.

Can I recommend that you make the code compliant with the WordPress Coding Standards?
Here are some links for more information:

• WordPress Coding Standards
• WordPress JavaScript Coding Standards

Thanks in advance! 👍