Fix loading of yaml content for ruby version newer than 3.1.0 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ruby 3.1.0, psych version 4.0.0 got introduced. Starting psych version 4.0.0 the `load` method defaults to `safe_load`. See ruby/psych#487 See https://stdgems.org/psych/ This got introduced to prevent users from accidentally load yaml content from untrusted user input. But now breaks certain patterns, when using the gem. See https://bugs.ruby-lang.org/issues/17866 To still allow users to load trusted documents, the `unsafe_load` method got introduced. See ruby/psych#488 I added a ruby version check for backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ruby 3.1.0, psych version 4.0.0 got introduced. Starting psych version 4.0.0 the
loadmethod defaults tosafe_load.See ruby/psych#487
See https://stdgems.org/psych/
This got introduced to prevent users from accidentally load yaml content from untrusted user input. But
now breaks certain patterns, when using the gem.
See https://bugs.ruby-lang.org/issues/17866
To still allow users to load trusted documents,
the
unsafe_loadmethod got introduced.See ruby/psych#488
I added a ruby version check for backwards
compatibility.