Skip to content

Commit

Permalink
Fix 5007 by adding build ver. to multi-arch build (kubeflow#7094)
Browse files Browse the repository at this point in the history
  • Loading branch information
lehrig authored and tzstoyanov committed Jun 14, 2023
1 parent 8f30a5e commit e3e3f2b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions components/centraldashboard/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,20 @@ docker-build:
docker build ${DOCKER_BUILD_OPTS} -t $(IMG):$(TAG) . \
--build-arg kubeflowversion=$(shell git describe --abbrev=0 --tags) \
--build-arg commit=$(COMMIT) \
--label=git-verions=$(TAG)
--label=git-version=$(TAG)
@echo Built $(IMG):$(TAG)

docker-push:
docker push $(IMG):$(TAG)

.PHONY: docker-build-multi-arch
docker-build-multi-arch: ## Build multi-arch docker images with docker buildx
docker buildx build --load --platform ${ARCH} --tag ${IMG}:${TAG} -f ${DOCKERFILE} .
docker buildx build --load --platform ${ARCH} --tag ${IMG}:${TAG} -f ${DOCKERFILE} . --build-arg kubeflowversion=$(shell git describe --abbrev=0 --tags) --build-arg commit=$(COMMIT) --label=git-version=$(TAG)


.PHONY: docker-build-push-multi-arch
docker-build-push-multi-arch: ## Build multi-arch docker images with docker buildx and push to docker registry
docker buildx build --platform ${ARCH} --tag ${IMG}:${TAG} --push -f ${DOCKERFILE} .
docker buildx build --platform ${ARCH} --tag ${IMG}:${TAG} --push -f ${DOCKERFILE} . --build-arg kubeflowversion=$(shell git describe --abbrev=0 --tags) --build-arg commit=$(COMMIT) --label=git-version=$(TAG)

# Build but don't attach the latest tag. This allows manual testing/inspection of the image
# first.
Expand Down

0 comments on commit e3e3f2b

Please sign in to comment.