cmds/core/hexdump: use constants and os.WriteFile #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrender
reviewed
Apr 10, 2023
The code was writing the file but not closing it, which could be trouble on some systems. The string of all letters was used more than once; make it a const. go test and tinygo test now both work, once #3646 WIP: fix else/defer bug goes in to tinygo. Signed-off-by: Ronald G. Minnich <rminnich@google.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
rminnich
force-pushed
the
tinygo_hexdump
branch
from
153480a
to
9dc44e2
Compare
|
tinygo-org/tinygo#3648 filed. |
andrewsun2898
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was writing the file but not closing it, which could be trouble on some systems.
The string of all letters was used more than once; make it a const.
go test and tinygo test now both work, once #3646 WIP: fix else/defer bug goes in to tinygo.