Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kexec: remove JSON confg file #2887

Merged
merged 4 commits into from
Feb 1, 2024
Merged

kexec: remove JSON confg file #2887

merged 4 commits into from
Feb 1, 2024

Conversation

hugelgupf
Copy link
Member

No description provided.

@hugelgupf hugelgupf force-pushed the cfg-file branch 2 times, most recently from 3cc972e to 8d735d4 Compare February 1, 2024 21:39
Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf marked this pull request as ready for review February 1, 2024 21:48
@hugelgupf hugelgupf requested a review from a team February 1, 2024 21:49
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6002e37) 77.37% compared to head (d1d8f24) 77.43%.

Files Patch % Lines
pkg/boot/linux.go 84.61% 4 Missing ⚠️
cmds/core/kexec/kexec_linux.go 50.00% 1 Missing ⚠️
pkg/boot/linux/load_linux_image.go 80.00% 1 Missing ⚠️
pkg/boot/linux/load_other_linux.go 0.00% 1 Missing ⚠️
pkg/boot/menu/menu.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2887      +/-   ##
==========================================
+ Coverage   77.37%   77.43%   +0.06%     
==========================================
  Files         431      430       -1     
  Lines       43153    43064      -89     
==========================================
- Hits        33388    33348      -40     
+ Misses       9765     9716      -49     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.40% <ø> (ø)
integration/generic-tests/...-amd64 17.63% <56.75%> (-0.35%) ⬇️
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 21.60% <68.42%> (-0.53%) ⬇️
integration/gotests/...-amd64 74.22% <29.72%> (+0.11%) ⬆️
integration/gotests/...-arm 75.53% <29.72%> (+0.12%) ⬆️
integration/gotests/...-arm64 75.42% <28.94%> (+0.11%) ⬆️
pkg/...-amd64 76.46% <35.13%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf force-pushed the cfg-file branch 2 times, most recently from 9ebd302 to e55d66d Compare February 1, 2024 22:32
@hugelgupf hugelgupf enabled auto-merge (rebase) February 1, 2024 22:32
Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf merged commit 4e8a138 into u-root:main Feb 1, 2024
26 checks passed
@hugelgupf hugelgupf deleted the cfg-file branch February 1, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants