Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in pre-play hook #525

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Handle errors in pre-play hook #525

merged 3 commits into from
Jun 22, 2022

Conversation

goto-bus-stop
Copy link
Member

An error in a source pre-play hook could cause the entire process to crash. Now we log the error but keep going as if the hook didn't exist.

@coveralls
Copy link

coveralls commented Jun 22, 2022

Coverage Status

Coverage decreased (-0.04%) to 78.316% when pulling 84fdb47 on pre-play-error into 564713e on default.

@goto-bus-stop goto-bus-stop enabled auto-merge (squash) June 22, 2022 20:49
@goto-bus-stop goto-bus-stop merged commit eedfb9b into default Jun 22, 2022
@goto-bus-stop goto-bus-stop deleted the pre-play-error branch June 22, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants