Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use original media titles in search results #1855

Closed
goto-bus-stop opened this issue Feb 10, 2021 · 0 comments · Fixed by #2359
Closed

Use original media titles in search results #1855

goto-bus-stop opened this issue Feb 10, 2021 · 0 comments · Fixed by #2359
Labels
p: high High priority

Comments

@goto-bus-stop
Copy link
Member

goto-bus-stop commented Feb 10, 2021 •
edited
Loading

From https://developers.google.com/youtube/terms/developer-policies#c.-implementing-youtube-features:

API Clients that use search functionality provided by YouTube API Services must not modify or replace the text, images, information, or other content of, the search results returned by those Services.

For example, API Clients must not merge or intermix results from sources other than YouTube and present them as YouTube search results.

This will also make it easier to pick the correct videos, since sometimes very different videos can have a similar derived artist+title.

This is also a server-side task: we will need to send the original title along in API responses.
@goto-bus-stop goto-bus-stop added the p: high High priority label Feb 10, 2021
goto-bus-stop added a commit to u-wave/core that referenced this issue May 18, 2022
@goto-bus-stop
Make artist, title optional when adding playlist items
87bb286 
If not given, üWave will use defaults from the media source.

This is important for u-wave/web#1855. Media
sources will respond with original titles in search and import requests.
When dragging those media into a playlist from search results, the
client will not send an artist and title field, and üWave will request
them from the media source again, but this time it will respond with
derived data.
@goto-bus-stop goto-bus-stop mentioned this issue May 18, 2022
Merged
goto-bus-stop added a commit that referenced this issue May 18, 2022
@goto-bus-stop
Use server-default artist/title when adding search results
0a7ebcd 
Closes #1855

When adding media from search we no longer submit the artist and title
to the server. This lets search implementations reply with original
metadata, and then we can derive an appropriate artist+title from that
when the media is actually added.
goto-bus-stop added a commit to u-wave/core that referenced this issue May 18, 2022
@goto-bus-stop
Make artist, title optional when adding playlist items (#516)
b1712f3 
If not given, üWave will use defaults from the media source.

This is important for u-wave/web#1855. Media
sources will respond with original titles in search and import requests.
When dragging those media into a playlist from search results, the
client will not send an artist and title field, and üWave will request
them from the media source again, but this time it will respond with
derived data.
@goto-bus-stop goto-bus-stop mentioned this issue May 18, 2022
Merged
goto-bus-stop added a commit that referenced this issue May 23, 2022
@goto-bus-stop
Use server-default artist/title when adding search results
2250c3a 
Closes #1855

When adding media from search we no longer submit the artist and title
to the server. This lets search implementations reply with original
metadata, and then we can derive an appropriate artist+title from that
when the media is actually added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use server-default artist/title when adding search results u-wave/web
1 participant
@goto-bus-stop