Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mobile layout #514

Merged
merged 39 commits into from
Mar 29, 2018
Merged

Add Mobile layout #514

merged 39 commits into from
Mar 29, 2018

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Dec 24, 2016

Depends: #504
Closes: #64

Todo:

  • Add Waitlist and User list somewhere
  • Add stripped-down PlaylistManager for showing individual playlists
  • Fix some of the weird margins in SettingsManager
  • Add small style for media items in RoomHistory, perhaps not showing votes unless item is selected
  • Show vote icons on top of video after a tap
  • Full-screen dialogs if in mobile layout
  • Probably more

@pledi
Copy link
Collaborator

pledi commented Dec 24, 2016

I think combining both waitlist and userlist might be good for mobile.

@goto-bus-stop
Copy link
Member Author

Note to self: all mobile specific css can go in mobile/ and have the relevant media query applied automatically using

@import "./mobile" (max-width: 768px);

@goto-bus-stop
Copy link
Member Author

goto-bus-stop commented Jan 1, 2017

Should lock the screen orientation to Landscape when fullscreen video is enabled:

https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/Managing_screen_orientation
https://w3c.github.io/screen-orientation/#locking-the-screen-orientation

e; And also probably use this mobile layout in portrait mode only.

@goto-bus-stop
Copy link
Member Author

Will wait for material-ui@1.0.0 before really continuing with this, I think. 1.0.0 will include better mobile support eg. for Dialogs so it'd be a waste to implement it here and then move it over once 1.0.0 is out.

@goto-bus-stop goto-bus-stop force-pushed the feature/mobile-really-for-once branch from b3c7113 to c3111d5 Compare April 8, 2017 07:56
@goto-bus-stop goto-bus-stop force-pushed the feature/mobile-really-for-once branch 2 times, most recently from 59dee35 to ee3b490 Compare April 20, 2017 17:05
@goto-bus-stop goto-bus-stop force-pushed the feature/mobile-really-for-once branch from 04a8968 to 7df31c7 Compare May 17, 2017 15:41
@goto-bus-stop goto-bus-stop force-pushed the feature/mobile-really-for-once branch 2 times, most recently from b3763e9 to 5d19b85 Compare June 17, 2017 11:39
@goto-bus-stop goto-bus-stop mentioned this pull request Jun 17, 2017
@goto-bus-stop
Copy link
Member Author

Hmm a volume control would be nice, since it defaults to 0% 😂

@goto-bus-stop
Copy link
Member Author

goto-bus-stop commented Sep 15, 2017

SoundCloud player on mobile can't autoplay, so we should show the audio element on the first SC track or something so users can allow it to play.

@goto-bus-stop
Copy link
Member Author

This is incomplete but rebasing all the time is a pain, so I'll merge it now and work on remaining issues later. I added a warning about it being crashy and in beta that shows up when you enter the mobile layout.

@goto-bus-stop goto-bus-stop merged commit aae59be into master Mar 29, 2018
@goto-bus-stop goto-bus-stop deleted the feature/mobile-really-for-once branch April 3, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants