-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mobile layout #514
Add Mobile layout #514
Conversation
I think combining both waitlist and userlist might be good for mobile. |
Note to self: all mobile specific css can go in mobile/ and have the relevant media query applied automatically using @import "./mobile" (max-width: 768px); |
Should lock the screen orientation to Landscape when fullscreen video is enabled: https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/Managing_screen_orientation e; And also probably use this mobile layout in portrait mode only. |
Will wait for material-ui@1.0.0 before really continuing with this, I think. 1.0.0 will include better mobile support eg. for Dialogs so it'd be a waste to implement it here and then move it over once 1.0.0 is out. |
36c16e1
to
b3c7113
Compare
b3c7113
to
c3111d5
Compare
59dee35
to
ee3b490
Compare
04a8968
to
7df31c7
Compare
b3763e9
to
5d19b85
Compare
Hmm a volume control would be nice, since it defaults to 0% 😂 |
5d19b85
to
f738e3e
Compare
SoundCloud player on mobile can't autoplay, so we should show the audio element on the first SC track or something so users can allow it to play. |
f738e3e
to
2ab05e8
Compare
2ab05e8
to
ea346b5
Compare
I like this API more.
This is incomplete but rebasing all the time is a pain, so I'll merge it now and work on remaining issues later. I added a warning about it being crashy and in beta that shows up when you enter the mobile layout. |
Depends: #504
Closes: #64
Todo: