Add a check to within to avoid panic on empty kdtree #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u1roh
approved these changes
Jan 9, 2023
|
Fixed a little: #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Love the crate, its powering parts of my microscopy particle detection algorithm. I just ran into a rare bug in which the kdtree I was querying against was empty, which resulted in a panic on line 18 in within.rs. I've just manually added a check to my code to ensure I never query against an empty kd-tree, but I thought you might have some interest in avoiding this edge-case as well.
Thanks for the great work :)