Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fanart.tv #4083

Closed
purevertigo opened this issue Nov 8, 2018 · 13 comments
Closed

Fanart.tv #4083

purevertigo opened this issue Nov 8, 2018 · 13 comments

Comments

@purevertigo
Copy link

purevertigo commented Nov 8, 2018

https://fanart.tv

any search hits an adblock redirects to this page

https://fanart.tv/membership-account/membership-levels/

@uBlock-user
Copy link
Contributor

uBlock-user commented Nov 8, 2018

@mapx- , does $badfilter work for you on @@/wp-content/plugins/google-analytics-for-wordpress/$first-party,script ?

@mapx-
Copy link
Contributor

mapx- commented Nov 8, 2018

No. The original filter in easyprivacy is:
@@/wp-content/plugins/google-analytics-for-wordpress/*$script,stylesheet,~third-party

so, it works:
@@/wp-content/plugins/google-analytics-for-wordpress/*$first-party,script,badfilter

@uBlock-user
Copy link
Contributor

uBlock-user commented Nov 8, 2018

Not sure I understand, @@/wp-content/plugins/google-analytics-for-wordpress/$first-party,script,badfilter doesn't work for me.

@uBlock-user
Copy link
Contributor

OKay why is @@/wp-content/plugins/google-analytics-for-wordpress/*$script,stylesheet,~third-party translated as @@/wp-content/plugins/google-analytics-for-wordpress/$first-party,script ?

Where did that $stylesheet directive disappear ?

@mapx-
Copy link
Contributor

mapx- commented Nov 8, 2018

In your filter is missing *

@mapx-
Copy link
Contributor

mapx- commented Nov 8, 2018

As I know, the complex filters are splitted for the various options: script, stylesheet etc

@uBlock-user
Copy link
Contributor

uBlock-user commented Nov 8, 2018

Yeah I got that, but where did $stylesheet disappear ? It's present in the original EasyPrivacy filter, so your filter shouldn't match.

@mapx-
Copy link
Contributor

mapx- commented Nov 8, 2018

I guess uBo creates 2 filters from that one

@@/wp-content/plugins/google-analytics-for-wordpress/$first-party,script
@@/wp-content/plugins/google-analytics-for-wordpress/$first-party,stylesheet

but removing * (maybe considering it superfluous - but having these weird consequences)

@uBlock-user
Copy link
Contributor

uBlock-user commented Nov 8, 2018

Hmmm, @@/wp-content/plugins/google-analytics-for-wordpress/*$script,stylesheet,~third-party,badfilter also works.

So in your case, the one without the $stylesheet directive is getting badfiltered.

@gorhill
Copy link
Member

gorhill commented Nov 8, 2018

It should be possible to bad-filter network filters shown in the logger. If it's not working then there is a bug.

On my side I get @@/wp-content/plugins/google-analytics-for-wordpress/$first-party,script in the logger, and bad-filtering it does not work: it's a bug. The actual issue is that uBO should log the filter with the asterisk at the end, otherwise the filter is outputted as a regex-based filter, which is not what the actual filter is.

@uBlock-user
Copy link
Contributor

On my side I get @@/wp-content/plugins/google-analytics-for-wordpress/$first-party,script in the logger, and bad-filtering it does not work: it's a bug.

Yes, that's what I'm facing too.

@okiehsch
Copy link
Contributor

okiehsch commented Nov 8, 2018

About the adblock redirect, I can't reproduce.

@gorhill
Copy link
Member

gorhill commented Nov 8, 2018

I could not reproduce either when I worked on the logger issue.

@okiehsch okiehsch closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants