https://github.com/easylist/easylist/issues/12147#issue-1251695641

[MasterKia]

easylist/easylist#12147 (comment)
Since EasyList maintainer @Khrin didn't like cooperating with the downstream.

All rules should be kept until PersianBlocker is added as default (hopefully).
The only rules which are too important and can't be removed are (until EasyList decides to add them):

tamin.ir#@#.ads2
@@||tamin.ir/content/ads/

[Yuki2718]

webii.ir##.ads-box appear to be indeed ads: https://www.webii.ir/cat/digital

[MasterKia]

##.ads-box

The website title is وب سایت تبلیغات و نیازمندیها درج آگهی رایگان which roughly translates to Free advertising (and selling stuff) website where you can submit your goods to sell.
Similar to eBay I'd say.

[Yuki2718]

Hmm, so the website itself is for ads. I'm not sure if we should unblock. Similar to #10149 (comment) , user can turn blocker off on such sites. @mapx- @okiehsch

[MasterKia]

Hmm, so the website itself is for ads. I'm not sure if we should unblock. Similar to #10149 (comment) , user can turn blocker off on such sites. @mapx- @okiehsch

It's not for ads per say, is eBay for ads where people can sell their own stuff?

[Yuki2718]

@@1000site.ir/home/ads/asset/favicon.ico unblocks ad too but it's addressed by your list (1000site.ir##.col-md-offset-6.col-md-3) and current IRN list (.ir/*/banner/). However, such cases are unlikely to be addressed by EL if the breakage is acceptable. Anyway you forgot ||.

[Yuki2718]

sourceiran.com/wp-content/uploads/300-250.jpg is self promotion and it's fair not to unblock:
https://easylist.to/pages/policy.html

Self-promotion should not be specifically removed by EasyList, although equally should not be allowed if it is blocked.

https://github.com/uBlockOrigin/uAssets

The rationale on whether to include a specific filter in one of uBO's own filter lists is the same as outlined by EasyList/EasyPrivacy policies

Anyway @@||sourceiran.com/wp-content/uploads/*.jpg alone doesn't work, sourceiran.com#@#.ads-widget is also needed - kinda too much to unblock single self-promo.

[MasterKia]

I'll take back sourceiran.com from uBlock unbreak but can I address it in PersianBlocker?

[Yuki2718]

I'll take back sourceiran.com from uBlock unbreak but can I address it in PersianBlocker?

Why not as that's your list?

[MasterKia]

sourceiran.com#@#.ads-widget is also needed

BTW I had added this in my list, but forgot to include it in this PR.

[MasterKia]

Similar to https://github.com/uBlockOrigin/uAssets/pull/10149#issuecomment-951821141

On that note, I noticed that clickyab.com (a Persian site dedicated to ads) is blocked in Pete Lowe's list and I did this:

@@||clickyab.com^$1p
||clickyab.com^$3p

Is this a wrong approach according to that comment from gorhill?

[mapx-]

usually
||clickyab.com^$badfilter

and not @@||clickyab.com^$1p

[Yuki2718]

cooldl.net#@#.ads-box
cooldl.net#@#.ads-content

self-promo too

[Yuki2718]

@@||beytoote.com/ads/images_pc/$image
@@||beytoote.com/ads/images_mob/$image

merge to single rule @@||beytoote.com/ads/images_$image,1p

[MasterKia]

usually ||clickyab.com^$badfilter

and not @@||clickyab.com^$1p

Fixed, I understand the concept of "badfilter" but does do any harm when unblocked using ^$1p?

[Yuki2718]

Fixed, I understand the concept of "badfilter" but does do any harm when unblocked using ^$1p?

Depends on site but can allow too much - there may be something to be blocked by generic rules.

[Yuki2718]

@@||beytoote.com/ads/js/$script,1p will be needed too (bottom slider broken).

[MasterKia]

Also @@||ads.beytoote.com/live_chat, breaks the chat function in beytoote.com/ads/advertising.php.

[Yuki2718]

Lastly can you take more detailed screenshot(s) of tamin.ir (DOM tree)? Some government sites actually deliver ads. Want to confirm they're not ads.

[MasterKia]

https://github.com/easylist/easylist/issues/12152#issue-1251779583:
https://user-images.githubusercontent.com/17685483/170851340-3e9db42b-bd2f-434c-93d9-dd502c04eb68.png
https://user-images.githubusercontent.com/17685483/170851305-73cd03da-b834-4a9f-a332-10b5a6b9934c.png
https://user-images.githubusercontent.com/17685483/170851388-6db8ee63-4ce4-4ea2-adb7-caf5c243f3b7.png

I could take more if you want.

[MasterKia]

[Yuki2718]

No need, so they're links to subpages of Iranian Social Security Organization.

[Yuki2718]

7edc8a7

[Yuki2718]

Adjusted a bit: 40a47e0 I'll copy them to AG list.

[MasterKia]

Should I keep them or remove them?
PersianBlocker if used with uBO and AG should be fine since these unbreak filters are present in both.

But if used with ABP (hopefully not :p), I guess they don't have an unbreak list and rely on EasyList.

[Yuki2718]

We want to keep minimal rules in our lists.

[MasterKia]

easylist/easylist#12152 (comment)

@ryanbr

Could you please tell me how that qualifies as spam?
I don't understand this hostility from @Khrin, the EL maintainer.
Does he have a problem with Persian websites?