-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New popup More and Less buttons do not always dissapear #1059
Comments
Also it looks like the Wiki is missing the documentation for the new advanced settings options. |
I tested the fix with uBO 1.45.3b7 on Firefox 107.0, and here is a case where the "More" and "Less" buttons still appear:
But they don't appear in this case:
Shouldn't the "More" and "Less" buttons not appear at all in the first case (since there isn't anything to expand/compress), and thus behave like the second case? |
It's because section |
While testing #2248 on Firefox 107.0 (64 bity) in a relatively fresh profile (profile recreated few days ago), I updated 1.45.2 to b9 (turn off in add-ons manager, install from release page, turn back on), popup was locked on minimum preset and more/less buttons mostly stopped working: simplescreenrecorder-2022-12-07_18.27.46.mp4On second try (after recreating profile again) all looked fine, but when I tried applying settings from #1059 (comment) my graphics freezed :| It's all probably because of me and my system, but can someone try again if it works fine after update? Details
|
Were there errors reported in browser console? |
I can reproduce. What I did:
|
I don't understand what you are saying there. You mean you paste the two lines at the end of advanced settings content? |
Yes, and settings are automagically updated after applying. |
AAAnd I cannot reproduce again :( Maybe it has something to do with number of clicks on buttons, or maybe some storage issue... No errors in console BTW. |
Ok, I can repro again, but this time I did not reset the settings to default in 45.2 before update to b10. Popup is still broken even after resetting advanced settings to default. |
Weird, when I look at the popup panel content through the browser inspector, I still see CSS declarations from the previous uBO version, i.e. the one that was using After restarting the browser, it seems fixed for me (maybe I restarted twice). So there is a Firefox issue somewhere which causes the old version of a file to still be used after an update. |
It's fine when updated without turning off uBO from add-on manager. |
Prerequisites
Description
When the advanced option
popupPanelLockedSections
is used, theLess
button in the new popup do not disappear when all non-locked sections are hidden.Similarly, when the advanced option
popupPanelDisabledSections
is used, theMore
button in the new popup do not disappear when all non-disabled sections are shown.A specific URL where the issue occurs
Advanced settings page.
Steps to Reproduce
popupPanelLockedSections
to 3Less
popupPanelDisabledSections
to 3More
Expected behavior:
The
Less
button would disappear when all non-locked sections are hidden.The
More
button would disappear when all non-disabled sections are shown.Actual behavior:
The
Less
button never disappears and stops responding to clicks when all non-locked sections are hidden.The
More
button never disappears and stops responding to clicks when all non-disabled sections are shown.Your environment
The text was updated successfully, but these errors were encountered: