Pressing and holding Ctrl causes a ui error in 'godmode'

[shc0743]

Prerequisites

• I verified that this is not a filter issue (MUST be reported at filter issue tracker)
• This is not a support issue or a question
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
• The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
• I checked the documentation to understand that the issue I report is not a normal behavior

I tried to reproduce the issue when...

• uBO is the only extension
• uBO with default lists/settings
• using a new, unmodified browser profile

Description

If I am advanced user (Important!) and I open uBlock popup panel in any page,
then press Ctrl for more than 1 second,
the green allow box will twinkle:


I tried to find out why this appear,
and (maybe) I found the problem source:

/js/popup-fenix.js , Line 1256

/*******************************************************************************

    Double tap ctrl key: toggle god mode

*/

{
    let eventCount = 0;
    let eventTime = 0;

    document.addEventListener('keydown', ev => {
        if ( ev.key !== 'Control' ) {
            eventCount = 0;
            return;
        }
        const now = Date.now();
        if ( (now - eventTime) >= 500 ) {
            eventCount = 0;
        }
        eventCount += 1;
        eventTime = now;
        if ( eventCount < 2 ) { return; }
        eventCount = 0;
        document.body.classList.toggle('godMode');
    });
}

It cause the 'godMode' class toggles very quickly, so the box twinkle.

A specific URL where the issue occurs

everywhere

Steps to Reproduce

1. Check "I am advanced user" in uBlock settings
2. Open a webpage
3. open uBlock origin popup page
4. Move the mouse to any box
   
5. press Ctrl key for more than 1 seconds

Expected behavior

godMode open and a green allow box appear

Actual behavior

The green allow box twinkle very quickly.
'godMode' is always toggling.
if I open DevTools, there is a 'godMode' twinkle in body's class:

uBlock Origin version

1.42.4

Browser name and version

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.0.0 Safari/537.36

Operating System and version

Windows 10 21H2 19044.1766

[gorhill]

Unable to reproduce. It seems your ctrl key may be auto-repeating, I don't think it should.

[shc0743]

Unable to reproduce. It seems your ctrl key may be auto-repeating, I don't think it should.

Yes, this is caused by auto repeating.
Maybe it is hardware related. I tested with my physics keyboard, it repeats and ev.repeat==true .
Open this test url and open DevTools to test data:text/html,<script src="data:text/javascript,document.addEventListener('keydown',function(ev){console.dir(ev)})"></script>Press any key to test
It repeats in my computer

But when I test with osk.exe (Windows Screen Keyboard), I can't reproduce.
I think you could add if (ev.repeat) return; and this will be solved.

[gwarser]

I can reproduce in VM Win10 in Firefox, Edge, Chrome and Opera - Windows thing?

[gorhill]

think you could add if (ev.repeat) return; and this will be solved.

Good idea, will do: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/repeat.

[krystian3w]

Fix works too on Windows 7.

To check Windows XP then needed is use MyPal 68 if is in good work latest stable and dev builds of uBo.

Vista may need use some of Chromium based 78 - 87 release (MyPal 68 may still works bad on Vista) to check it.

If XP and Vista don't repeat button then this is added in 2009 to Windows 7 or later by e.g. KB update (no planed for XP and Vista).