Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Update now" button flashes for 1 second before changing the count numbers #248

Closed
MS-PC opened this issue Sep 29, 2018 · 3 comments
Closed
Labels
bug Something isn't working fixed issue has been addressed

Comments

@MS-PC
Copy link

MS-PC commented Sep 29, 2018

Description

This I do not consider a problem, but something annoying. After checking all filter lists for "Force update", then "Update now" and notice that the "Update now" button flashes for 1 second before changing the count numbers of: Network filters + Cosmetic filters.

Your environment

  • uBlock Origin version: 1.17.0
  • Browser Name and version: Firefox 62.0.2
  • Operating System and version: Windows 8.1
@gwarser
Copy link

gwarser commented Sep 29, 2018

Flashes once (changes to active state for a moment) just before update ends.

@gwarser gwarser added the bug Something isn't working label Sep 29, 2018
@uBlock-user
Copy link
Contributor

seen since the beginning, thought this was by-design.

@gorhill
Copy link
Member

gorhill commented Oct 24, 2018

Notes for future reference when I forget why this happened:

The glitch occurs before the last "asset updated" notification occurs, and after the "all assets updated" notification occurs.

The last "asset updated" notification occurs before the "all assets updated" notification because "asset updated" is fired after the data has been confirmed written to cache storage, while the "all assets updated" is fired as soon as the asset is successfully downloaded (i.e. before it is actually written to cache storage).

The fix will be to fire "asset updated" without waiting for confirmation that the asset's content has been effectively written to cache storage.

@gwarser gwarser added the fixed issue has been addressed label Oct 24, 2018
gorhill added a commit to gorhill/uBlock that referenced this issue Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants