Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block element preview window overlays object to be blocked. #615

Closed
8 tasks done
truthsword opened this issue Jun 2, 2019 · 16 comments
Closed
8 tasks done

Block element preview window overlays object to be blocked. #615

truthsword opened this issue Jun 2, 2019 · 16 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@truthsword
Copy link

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Many websites have popup video window that locates itself in the lower right corner of the web page. When "Block element" is called to remove it the "Block element" windows also locates to the lower right corner, obscuring the video element I want to block, and I am unable to see the effect when choosing blocking elements to preview.
There needs to be a means to drag the Block element window to another part of the screen, so that Preview effect may be seen.

A specific URL where the issue occurs

There are many... here is one...
https://www.jpost.com

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. Open web page, scroll down to cause video pop-out window to jump to lower right corner of browser.
  2. Open uBlock's "Block element"
  3. "Block element" window sits on top of undesired video pop-out window.

Expected behavior:

Relocate "Block element" window to another part of the screen to reveal undesired video pop-out window.

Actual behavior:

Can't detect uBlock Preview action.

Your environment

  • uBlock Origin version: 1.19.6
  • Chrome Version 74.0.3729.169 (Official Build) (64-bit)
  • Operating System and version: Win10 x64
@uBlock-user
Copy link
Contributor

scroll down to cause video pop-out window to jump to lower right corner of browser

That doesn't happen on my end.

@uBlock-user uBlock-user added unable to reproduce cannot reproduce the issue something to address something to address labels Jun 2, 2019
@gorhill
Copy link
Member

gorhill commented Jun 2, 2019

I can also not reproduce.

When I move the mouse pointer outside the picker dialog, the dialog fades away which may give the impression that it's being overlapped, but bringing the mouse back inside and the dialog returns and renders properly.

@uBlock-user
Copy link
Contributor

Element picker iframe is always placed at the top of all other frames and never under so this would never occur in the first place.

@truthsword
Copy link
Author

Page loads with pop-out video
video before picker

Picker selected/video obscured
video after picker

@uBlock-user uBlock-user removed the unable to reproduce cannot reproduce the issue label Jun 2, 2019
@gorhill
Copy link
Member

gorhill commented Jun 2, 2019

Oh I understand now, I misunderstood, I thought you meant the picker was underneath the video widget.

Just move the mouse outside the picker dialog, it will fade away revealing what is under.

@gorhill
Copy link
Member

gorhill commented Jun 2, 2019

Ok, being able to drag the dialog out of the way would help when trying different suggested choices.

@truthsword
Copy link
Author

Ok, being able to drag the dialog out of the way would help when trying different suggested choices.

Yes... So I cannot tell which filter has an affect as when I click preview the effect on the video window is unknown.

@uBlock-user uBlock-user added the enhancement New feature or request label Jun 2, 2019
@gorhill
Copy link
Member

gorhill commented Jun 2, 2019

I'm reading the steps-to-reproduce and expected behavior again and I have no clue how I ended up misunderstanding the issue. Sorry about this.

@truthsword
Copy link
Author

No problem. A workaround is to narrow the browser window. Apparently the picker window and video resize differently, so I managed for force the video to extend enough beyond the picker window to select a filter. I'm not sure that is doable on other sites, but it may help.

@uBlock-user uBlock-user removed the something to address something to address label Jun 2, 2019
@kulfoon
Copy link

kulfoon commented Jun 3, 2019

Me too encountered the issue x times while trying to block something which was placed at bottom-right corner.

gorhill : Ok, being able to drag the dialog out of the way would help when trying different suggested choices.

Yes, or another solution is an 9 directional pad button in Element Picker's window - an user clicks a desired direction/arrow and the window is moved there:

@krystian3w
Copy link

krystian3w commented Jun 9, 2019

Try this:

https://userstyles.org/styles/168306/move-ublock-origin-element-picker, no possible better with CSS only. I no support *-center element picker in my CSS.

left-top center-top right-top
left-bottom center-bottom (default in uBo)

@setanarut
Copy link

Does anyone interested in this problem. Using Stylish is not a real solution.

bug

@krystian3w

This comment has been minimized.

@setanarut

This comment has been minimized.

@uBlockOrigin uBlockOrigin locked and limited conversation to collaborators Oct 28, 2019
@uBlock-user uBlock-user added the fixed issue has been addressed label Nov 5, 2019
@uBlockOrigin uBlockOrigin unlocked this conversation Nov 5, 2019
@uBlock-user
Copy link
Contributor

Available with 1.23.1b17

@gwarser
Copy link

gwarser commented Nov 5, 2019

Dialog can be dragged by empty space between buttons. Something worth mentioning in wiki.

gorhill/uBlock@d199577

gorhill added a commit to gorhill/uBlock that referenced this issue Nov 6, 2019
ryanbr pushed a commit to brave/uBlock that referenced this issue Nov 12, 2019
Related issue:
- uBlockOrigin/uBlock-issues#615

There is a grab area under the text area, to be used
to move the dialog around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

7 participants