Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelisting behind-the-scene causes uBO to disregard the moz-extension-scheme rule #651

Closed
8 tasks
Hifexar opened this issue Jul 3, 2019 · 14 comments
Closed
8 tasks

Whitelisting behind-the-scene causes uBO to disregard the moz-extension-scheme rule #651

Hifexar opened this issue Jul 3, 2019 · 14 comments
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed

Comments

@Hifexar
Copy link

Hifexar commented Jul 3, 2019 •
edited
Loading

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

[Description of the bug or feature]
moz-extension-scheme * * block - does not work

In white list:
"# about-scheme"
"# chrome-extension-scheme"
"# chrome-scheme"
"# moz-extension-scheme"
"# opera-scheme"
"# vivaldi-scheme"
"# wyciwyg-scheme"

But the lock does not work. How to reproduce bug:

  1. Disable white lists.
  2. Update the filter lists.
  3. See, that they are updated, although must be blocked.

uBlock Origin v1.20.3b0
firefox 67.0.4 x64

behind-the-scene * * block - does not work as well.
I don't know how to fake it. But I saw in the log that the request was not blocked.

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. Disable white lists.
  2. Update the filter lists.
  3. See, that they are updated, although must be blocked.

Expected behavior:

[What you expected to happen]

Actual behavior:

[What actually happened]

Your environment

  • uBlock Origin version:
  • Browser Name and version:
  • Operating System and version:
@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019 •
edited
Loading

And for some reason time in a log not local. Why?

@gorhill
Copy link
Member

gorhill commented Jul 3, 2019 •
edited
Loading

Fill in the information properly as requested please. I could not reproduce with the information you provided.

a

b

@gorhill gorhill added the unable to reproduce cannot reproduce the issue label Jul 3, 2019
@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019

screenshots:

  1. https://gyazo.com/aa8feda34a568fb69a4e4d45bf40e2c6
  2. https://gyazo.com/e83861ab2a70568b4388f4f44e816692
  3. https://gyazo.com/27d59052ae13f6c3f46991dd265ae989
  4. https://gyazo.com/76183b17fb17e80307ac6a88edf49417
    And plus even more precise blocking:
    https://gyazo.com/e7526cb850a9f18d9a834d32d5cc3e91
    https://gyazo.com/11ed985067aedda47c220aee42fee912

OS: Win7pro Sp1 x64
uBlock Origin v1.20.3b0
firefox 67.0.4 x64

I'm sorry, I don't understand, but what other information do you need?

@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019 •
edited
Loading

I'm sorry, it's my mistake. I found out. It turns out that if you whitelist behind-the-scene, the Moz-extension-scheme lock is ignored. I thought they were different things, separate.

@uBlock-user uBlock-user added the Firefox specific to Firefox label Jul 3, 2019
@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019 •
edited
Loading

And yet, here is an example when behind-the-scene is not blocked.
https://gyazo.com/b68c6e0de5e8047e3e654e7aef868f0e
in rule:
https://gyazo.com/706025ce8e6c2cfbb4c371c7a4529757

@gorhill gorhill reopened this Jul 3, 2019
@gorhill
Copy link
Member

gorhill commented Jul 3, 2019

I need to investigate why whitelisting behind-the-scene causes uBO to disregard the moz-extension-scheme rule -- I was not expecting this.

@uBlock-user uBlock-user added invalid not a uBlock issue something to address something to address and removed invalid not a uBlock issue unable to reproduce cannot reproduce the issue labels Jul 3, 2019
@uBlock-user uBlock-user changed the title moz-extension-scheme * * block - does not work Whitelisting behind-the-scene causes uBO to disregard the moz-extension-scheme rule Jul 3, 2019
@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019 •
edited
Loading

Another example of when not locked behind-the-scene:
https://gyazo.com/55124362315ae46122df3f0b0ded440c
in rule:
https://gyazo.com/706025ce8e6c2cfbb4c371c7a4529757

@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019

Or maybe these queries are not behind the scene, but then why are they displayed in the log in behind-the-scenes queries?

@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019 •
edited
Loading

Umatrix correctly identifies these requests as behind-the-scenes requests and blocks them. But ublock does not block.
https://gyazo.com/bc62c889e0f4610317e655b331231426

@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019 •
edited
Loading

To simulate such a non-blocking request, you need to hold an open tab with one of the screenshots from my previous messages.
https://gyazo.com/d9cb964dce42239c07e551d952620f9f

in umatrix log:
https://gyazo.com/70a0d160f50bb19adc6d9d9d5ff738d9

And how to make local time in umatrix, ublock logs? It is shown at me not in +3, and in 0.

P.S. Such requests for some reason appear even when I have not opened any tab with a screenshot. Where do they come from, who generates them? Workers are off. One such case noticed after closing all the tabs with screenshots.

@Hifexar
Copy link
Author

Hifexar commented Jul 3, 2019

Where to read about what a side means?
What is it?
https://gyazo.com/0194bcb143c4a7edc927a8d4d4638a4b

@uBlock-user
Copy link
Contributor

uBlock-user commented Jul 3, 2019 •
edited
Loading

Read the wiki for the partyness information and please stop adding questions after questions inturn adding noise/spam to this bug.

@uBlockOrigin uBlockOrigin locked and limited conversation to collaborators Jul 3, 2019
@gorhill
Copy link
Member

gorhill commented Jul 3, 2019 •
edited
Loading

how to make local time in umatrix, ublock logs?

It is local time. Verify if any about:config setting is interfering, for example privacy.resistFingerprinting.

@gorhill
Copy link
Member

gorhill commented Jul 3, 2019 •
edited
Loading

Read the wiki for the partyness information

To be fair, the wiki has not been updated to account for that new column in the logger. Something else to fix. Some information in the release notes: https://github.com/gorhill/uBlock/releases/tag/1.18.0.

@uBlockOrigin uBlockOrigin unlocked this conversation Jul 3, 2019
@uBlock-user uBlock-user added bug Something isn't working and removed something to address something to address labels Jul 3, 2019
gorhill added a commit to gorhill/uBlock that referenced this issue Jul 5, 2019
@gorhill
Fix whitelist status evaluation of tabless network requests
ae56c4d 
Related issue:
- uBlockOrigin/uBlock-issues#651

The `behnind-the-scene` context was wrongly used to
evaluate the whitelist status of the context of tabless
network requests. The document origin must be used
instead when it's available.

Additionally, much code has been revisited for better
ES6 syntax compliance.
@uBlock-user uBlock-user added the fixed issue has been addressed label Jul 5, 2019
@Hifexar Hifexar mentioned this issue Jul 8, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gorhill @uBlock-user @Hifexar