fix: disabling options rendering on non-home paths #703
Conversation
| $scope.renderMe = false; | ||
| if ( | ||
| $location.url().indexOf(expanded) > -1 || | ||
| $location.url().indexOf(compact) > -1 |
There was a problem hiding this comment.
Is this a temporary or permanent fix? If permanent, any worries that someday there will be a "Mayflower Compact" app and weirdly the expand/contract widget is going to start showing on its details page? heh.
There was a problem hiding this comment.
I think "permanent" in the same sense that our current solution to toggling modes is "permanent."
That said, it's probably worth looking for a better long-term solution for toggling expanded/compact modes, which would presumably change this implementation as well.
There was a problem hiding this comment.
yeah, we're just finding all the edges of customization that we made in uw-frame to support angularjs-portal. This is as permanent as we want it to be. This will be temporary as long as we make efforts to transform angularjs-portal into "just another frame app".
There was a problem hiding this comment.
actually, you're right @apetro, this would break if any entities have expanded or compact in their paths. this should really be a startsWith
many thanks to @Doug-Reed for finding the bug and @thevoiceofzeke for helping fix it.
Contributor License Agreement adherence: