Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape search param string #2425

Merged
merged 1 commit into from
Sep 11, 2021
Merged

fix: escape search param string #2425

merged 1 commit into from
Sep 11, 2021

Conversation

bjagg
Copy link
Member

@bjagg bjagg commented Sep 10, 2021 •
edited
Loading

Checklist
Description of change

Can add scripting in via search feature.

To reproduce:

  1. Start uPortal
  2. visit http://localhost:8080/uPortal/p/search.ctf2/max/render.uP?pP_query=1234'+alert(5678)+'

@bjagg bjagg added the bug label Sep 10, 2021
@bjagg bjagg self-assigned this Sep 10, 2021
ChristianMurphy
ChristianMurphy approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to escape this 👍

@bjagg bjagg merged commit 7c0d332 into uPortal-Project:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@jonathanmtran jonathanmtran jonathanmtran approved these changes

@jgribonvald jgribonvald Awaiting requested review from jgribonvald

@cbeach47 cbeach47 Awaiting requested review from cbeach47

Assignees

@bjagg bjagg

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjagg @jonathanmtran @ChristianMurphy