feature/UPSE-286 update to support Java 11 #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks @mgillian! uPortal/.github/workflows/CI.yml Lines 22 to 23 in cb1d533 Adding - 11to the list? |
|
done.
Michael
…On Thu, Jun 16, 2022 at 1:44 PM Christian Murphy ***@***.***> wrote:
Nice, thanks @mgillian <https://github.com/mgillian>!
Could we add Java 11 to the CI test matrix, here:
https://github.com/uPortal-Project/uPortal/blob/cb1d5335b9209d6214777fefdce9c641ba083e14/.github/workflows/CI.yml#L22-L23
Adding
- 11
to the list?
—
Reply to this email directly, view it on GitHub
<#2504 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN6DZOCCCT6QKYJEHT7663VPOG3JANCNFSM5ZAADR3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
It looks like the Zulu flavor of Java on Windows is working, but is timing out before it could finish. uPortal/.github/workflows/CI.yml Line 25 in cb1d533 To give a bit more wiggle room for builds that take longer. 30 min, 45 min, or even 60 min would probably be fine. |
|
Did you watch if this fix the issue: uPortal-Project/uPortal-start#570 ? |
jgribonvald
reviewed
Jul 25, 2022
There was a problem hiding this comment.
I've tested the build locally to see what happen, and it's building.
After there is a lot of warning with error prone on code...
@mgillian are you deploying this uPortal build ?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Provide support for build/install against Java 11, as well as Java 8