Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct some Less entries #2609

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Conversation

bjagg
Copy link
Member

@bjagg bjagg commented Dec 22, 2022

Checklist
Description of change

A deployer reported build failing due to some Less lint issues. This PR represents the corrections to pass the tests.

@ChristianMurphy
Copy link
Member

Less file looks good, thanks @bjagg!

In an unrelated turn of events, the jquery webjar seems to have gone missing from maven central?
https://github.com/uPortal-Project/uPortal/actions/runs/3761870066/jobs/6394795730#step:4:32

@bjagg
Copy link
Member Author

bjagg commented Dec 23, 2022

That is a very very old version. Maybe it's time to remove it?

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Dec 23, 2022

Restarted CI again this morning to see if it was a temporary resolution issue. ♻️

Also started a redeploy of jstree on webjars to see if that will help 🏗️

That is a very very old version. Maybe it's time to remove it?

ideally yes.
Though this is a transitive dependency, through jstree, we'd need to wait for an upgrade there (which may be a bit, the author is recovering from an injury according to the project readme), or replace jstree with another library.

@jgribonvald
Copy link
Contributor

Restarted CI again this morning to see if it was a temporary resolution issue. ♻️

Also started a redeploy of jstree on webjars to see if that will help 🏗️

That is a very very old version. Maybe it's time to remove it?

ideally yes. Though this is a transitive dependency, through jstree, we'd need to wait for an upgrade there (which may be a bit, the author is recovering from an injury according to the project readme), or replace jstree with another library.

In my context I'm using custom web-components in place, because in several case we need only small component or a component with few features so which is really small. For complexe case we can find and use library for that.

@bjagg
Copy link
Member Author

bjagg commented Dec 23, 2022

Yay -- it passed!

@bjagg bjagg merged commit bd19c23 into uPortal-Project:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants