Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UP-4263 : Add RedirectRenderingPipelineTerminator #436

Merged
merged 3 commits into from
Oct 22, 2014

Conversation

apetro
Copy link
Member

@apetro apetro commented Oct 10, 2014

Add a RedirectRenderingPipelineTerminator IPortalRenderingPipeline implementation that simply redirects to a configured path, terminating the rendering pipeline.

See JIRA UP-4263 and context on MyUW's conditionally terminating the rendering pipeline in a redirect.

Logging

Logs at TRACE useful for development and troubleshooting.

TRACE o.j.p.r.BranchingRenderingPipeline - Branching to the true pipe [RedirectRenderingPipelineTerminator which redirects to /web .].

Configuration example

Here's how MyUW is conditionally using this terminator.

<!-- This valve takes the place of the out of the box beginning of the pipeline, wrapping that ootb pipeline as one of the downstream branches, and redirecting as the other branch, depending upon a Predicate. -->
  <bean id="portalRenderingPipeline" class="org.jasig.portal.rendering.BranchingRenderingPipeline">
        <qualifier value="main" />
        <property name="predicate">
            ...
        </property>
        <property name="truePipe" ref="redirectToWeb" />
        <property name="falsePipe" ref="dynamicRenderingPipeline" />
    </bean>

    <bean id="redirectToWeb" class="org.jasig.portal.rendering.RedirectRenderingPipelineTerminator">
        <property name="redirectTo" value="${angular.landing.page}" />
    </bean>

@apetro
Copy link
Member Author

apetro commented Oct 17, 2014

Looks like a false failure report from Travis-CI because of uPortal build resource starvation.

@timlevett
Copy link
Contributor

👍

jameswennmacher pushed a commit that referenced this pull request Oct 22, 2014
UP-4263 : Add RedirectRenderingPipelineTerminator
@jameswennmacher jameswennmacher merged commit 3d2265b into uPortal-Project:master Oct 22, 2014
@apetro apetro deleted the UP-4263 branch March 21, 2016 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants