Brand model #10
Brand model #10
Conversation
|
Build will NOT pass - this requires an update of the ref-impl and an npm publish first! |
|
Mind splitting that PR up? Looks like it's addressing a bunch of different things (the spec, test cases, etc.). |
commenthol
force-pushed
the
brand-model
branch
from
6c34bc5
to
2804df5
Compare
| @@ -1,72 +1,104 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Please keep pull request focused on one topic.
commenthol
force-pushed
the
brand-model
branch
from
2804df5
to
c96f0b8
Compare
|
Should be focused now. |
|
|
||
| - user_agent_string: 'AdsBot-Google-Mobile (+http://www.google.com/mobile/adsbot.html) Mozilla (iPhone; U; CPU iPhone OS 3 0 like Mac OS X) AppleWebKit (KHTML, like Gecko) Mobile Safari' | ||
| family: 'Spider' | ||
| family: 'Spider Smartphone' |
There was a problem hiding this comment.
Changed to family: 'Spider'
|
Why add a new file instead of appending them to |
commenthol
force-pushed
the
brand-model
branch
from
c96f0b8
to
0f8dc20
Compare
|
The testset is quite large (15799 testcases). As mentioned on the forum there was the idea of having a small and a big testset for the different language parsers to process. |
commenthol
force-pushed
the
brand-model
branch
from
0f8dc20
to
fbd1861
Compare
Yeah, that's an orthogonal issue. The "small" test suite should just exercise proper implementation of the spec and regex file (possibly even through made-up UA strings).
Yes please. I'd like to have 1 file for each one of UA, OS and device. |
commenthol
force-pushed
the
brand-model
branch
from
17cde7b
to
9a3c97d
Compare
|
All tests are now in |
commenthol
force-pushed
the
brand-model
branch
from
9a3c97d
to
b3a6e3e
Compare
|
ping... |
|
Doesn't seem to merge properly, mind looking into it? |
|
Travis CI still uses uap-ref-impl@0.1.0 (See line 111). In order to pass all tests, npm requires an update of "uap-ref-impl" with the version 0.2.0 checked in. Paste this into your terminal... # clone repo
git clone https://github.com/ua-parser/uap-ref-impl.git
cd uap-ref-impl
# pack the stuff
npm pack
# take a look whats inside
tar tvzf uap-ref-impl-0.2.0.tgz
# ... and out with it ... ;)
npm publish |
|
Oh, sorry, I thought there was a merge conflict, not a test suite issue. My bad. |
Adds Brand-Model parsing. Detects a lot of new Devices and Brands.
Tests are currently separate withing
tests/test_device_brandmodel.yaml.