Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: crash after Grouper update #186

Closed
zoidy opened this issue Jan 4, 2024 · 0 comments · Fixed by #187
Closed

Bug: crash after Grouper update #186

zoidy opened this issue Jan 4, 2024 · 0 comments · Fixed by #187
Assignees
Labels
bug Something isn't working p1 Issues affecting production, multiple users

Comments

@zoidy
Copy link
Collaborator

zoidy commented Jan 4, 2024

Describe the bug
A Grouper update on 1/3/2024 results in the program crashing when dropping members from a group

Reproduction Steps
Run ReQUIAM as normal

Outputted Messages

Traceback (most recent call last):
  File "/opt/redata/ReQUIAM/./scripts/script_run", line 306, in <module>
    d.synchronize()
  File "/opt/redata/ReQUIAM/requiam/delta.py", line 128, in synchronize
    if rsp_j['WsDeleteMemberResults']['resultMetadata']['resultCode'] not in 'SUCCESS':
KeyError: 'WsDeleteMemberResults'

Version information

  • ReQUIAM version: 1.10
  • ReQUIAM branch info: master

Expected behavior
No crash occurs

Additional context
Email from IT explains the change:

some Grouper WS calls out there had been using an incorrect field. This is an example:

{"WsRestDeleteMemberRequest": {"replaceAllExisting": "F", "subjectLookups": [{"subjectId": "100737682299"}]}}

The "replaceAllExisting": "F" never applied to WsRestDeleteMemberRequest and should be removed.

@zoidy zoidy added bug Something isn't working p1 Issues affecting production, multiple users labels Jan 4, 2024
@zoidy zoidy self-assigned this Jan 4, 2024
@zoidy zoidy linked a pull request Jan 5, 2024 that will close this issue
@zoidy zoidy closed this as completed in #187 Jan 5, 2024
zoidy added a commit that referenced this issue Jan 5, 2024
@yhan818 yhan818 mentioned this issue Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 Issues affecting production, multiple users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant