Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify adblock rules not accepted #1203

Closed
uazo opened this issue Jun 11, 2024 Discussed in #1197 · 6 comments
Closed

Verify adblock rules not accepted #1203

uazo opened this issue Jun 11, 2024 Discussed in #1197 · 6 comments
Labels
need triage I will look into it, I promise!

Comments

@uazo
Copy link
Owner

uazo commented Jun 11, 2024

Discussed in #1197

Originally posted by Rajraimatrix June 8, 2024
adblocker is working fine with some additional filters but i was unable to block pop up on many sites.

@uazo uazo added the need triage I will look into it, I promise! label Jun 11, 2024
@frank-owen
Copy link

I've noticed quite a few sites that have pop up elements that are removed with an annoyances filter when using uBO (Firefox)/adblock-rust (Brave) which Cromite doesn't remove. I assumed this was a limitation of Adblock Plus. This would be a big improvement for Cromite as the better adblocking capabilities is the sole reason I use Firefox and Brave rather than Cromite.

@uazo
Copy link
Owner Author

uazo commented Jun 14, 2024

I assumed this was a limitation of Adblock Plus

no, the mistake is mine, see #1197 (comment)

@ruboard
Copy link

ruboard commented Jun 16, 2024

A very simple example of a filter not working imginn.com##.Block-sulvo (Custom Rules)

Details

Screenshot_20240616-143632
https://imginn.Com/taylorswift/

ps worked on bromite!

@uazo
Copy link
Owner Author

uazo commented Jun 19, 2024

@ruboard rule is wrong, the correct one is

imginn.com##.block-h12

@uazo
Copy link
Owner Author

uazo commented Jun 19, 2024

[10980:20464:0611/114112.118:INFO:flatbuffer_converter.cc(128)] [eyeo] Invalid url filter: ||html-load.cc^$document,popup
[10980:20464:0611/114112.118:INFO:url_filter.cc(129)] [eyeo] Exception options can only be used with allowing filters
[10980:20464:0611/114112.118:INFO:flatbuffer_converter.cc(128)] [eyeo] Invalid url filter: ||html-load.com^$document,popup

It looks like an upstream error.
in https://gitlab.com/eyeo/adblockplus/chromium-sdk/-/blob/eyeo-126-dev/components/adblock/core/converter/parser/url_filter_options.cc?ref_type=heads#L219 from what I understand, exceptions begin with ~, but that doesn't seem to be the case in the code.

@uazo
Copy link
Owner Author

uazo commented Jun 19, 2024

see #560 (comment)

@uazo uazo closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need triage I will look into it, I promise!
Projects
None yet
Development

No branches or pull requests

3 participants