Fix for #336 - Divide-by-zero error for Attrib value=0 and has_usage #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_usage=True This adds a try/except block in generate_guauge_data_from_usage() (why the misspelling?) to catch for divide by zero errors. If value=0, we set the percent used to 100% (arbitrary, but better than an exception)
And a ValueError exception in generate_guauge_data_from_usage()
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a try/except block in generate_guauge_data_from_usage() (why
the misspelling?) to catch for divide by zero errors. If value=0, we
set the percent used to 100% (arbitrary, but better than an exception)