Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase Refactor #16

Merged
merged 16 commits into from
May 5, 2024
Merged

Codebase Refactor #16

merged 16 commits into from
May 5, 2024

Conversation

ElioDiNino
Copy link
Member

@ElioDiNino ElioDiNino commented May 5, 2024

Description

  • Fixed configure script to be fully cross platform compatible (due to issue with sed platform inconsistencies)
  • Removed the custom arm pre-req script since the default one works
  • Updated the default params to ArduPilot's current defaults
  • Bumped all action versions to resolve Node 16 warnings
  • Docker workflow now allows you to choose to build only copter or plane (instead of requiring both)
  • crossBuild.sh
    • Fixed missing version argument
    • Updated QEMU image
    • Added local cache persistance
  • Followed better practices in both Dockerfiles and updated to Ubuntu 22.04

Type of change

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Ran all builds locally
  • Ran GitHub workflows off this branch

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@ElioDiNino ElioDiNino self-assigned this May 5, 2024
@ElioDiNino ElioDiNino added Priority: High Status: Review Needed Awaiting approval from a lead Type: Bug Something isn't working Type: CI/CD Continuous Integration/Deployment configuration Type: Cleaning / Optimization Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request labels May 5, 2024
@ElioDiNino ElioDiNino marked this pull request as ready for review May 5, 2024 17:57
@ElioDiNino ElioDiNino added this pull request to the merge queue May 5, 2024
Merged via the queue into master with commit 0bb8ee7 May 5, 2024
5 checks passed
@ElioDiNino ElioDiNino deleted the refactor/arm branch May 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Status: Review Needed Awaiting approval from a lead Type: Bug Something isn't working Type: CI/CD Continuous Integration/Deployment configuration Type: Cleaning / Optimization Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants