feat(Update functionality on ID page) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubemacapuno
commented
May 7, 2023
There was a problem hiding this comment.
We are reusing functions/props here. For example, this shares a lot in common with the /dishes +page.svelte file. This works for now, but consider refactoring to use centralized helper functions or a reusable component.
Ex: addIngredient, removeIngredient, etc. Think of a way to make these reusable so that we're not bloating the <script> section on future +page.svelte files.
ubemacapuno
commented
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added update functionality for dishes/[_id]
Details:
Modal and Superforms form for updating dishes on dishes/[_id] route
References:
Superforms - for form library
capa-tracker - for Modal component
Screenshots:
[_id] page:
Modal:
