Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Allow specifying arcanist path #23

Merged
merged 3 commits into from
Jun 6, 2015
Merged

Allow specifying arcanist path #23

merged 3 commits into from
Jun 6, 2015

Conversation

ascandella
Copy link
Contributor

Fixes #19

Potentially partially fixes #21, since you could put in the path that the tool gets output to.

@ascandella
Copy link
Contributor Author

Tested manually by moving my /usr/local/bin/arc to /usr/local/bin/arc-bak and configuring the global setting to point to the arc-bak binary. Not sure if this is the optimal solution though.

@joshuaspence @lavahot what do you think?

@ascandella
Copy link
Contributor Author

@jjx @erikformella to review

ascandella
ascandella reviewed Jun 6, 2015
View reviewed changes
src/main/java/com/uber/jenkins/phabricator/PhabricatorBuildWrapper.java
final Map<String, String> envAdditions = new HashMap<String, String>();
envAdditions.put(PhabricatorPlugin.WRAP_KEY, "true");
envAdditions.put(PhabricatorPlugin.ARCANIST_PATH, arcPath);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really wish there was a better way to share data between the two plugins, since this repo is essentially a build wrapper (environment setup) and a notifier (record the result), but i don't want people to have to configure things twice in the global configuration. is there a better pattern for this?

@ascandella ascandella mentioned this pull request Jun 6, 2015
Closed
@lavahot
Copy link

lavahot commented Jun 6, 2015

@sectioneight Wait, how do you have arcanist installed? Is /usr/local/bin/arc a symlink? Don't you have /some/path/arcanist/bin/arc somewhere?

@ascandella
Copy link
Contributor Author

yes, we set it up via homebrew

readlink /usr/local/bin/arc-bak
../Cellar/arcanist/tip/bin/arc

@ascandella ascandella mentioned this pull request Jun 6, 2015
Closed
ascandella added a commit that referenced this pull request Jun 6, 2015
@ascandella
Merge pull request #23 from uber/custom-arc
8576e74 
Allow specifying arcanist path
@ascandella ascandella merged commit 8576e74 into master Jun 6, 2015
@ascandella ascandella deleted the custom-arc branch June 6, 2015 05:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin isn't compatible with Custom Tools Set Arc location in Jenkins UI
2 participants
@ascandella @lavahot