Try methods should return false for missing values #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibsm
approved these changes
Jun 27, 2017
static_provider_test.go
Outdated
| assert := assert.New(t) | ||
| p := NewStaticProvider(nil) | ||
| t.Run("int", func(t *testing.T) { | ||
| _, ok := p.Get("missing").TryAsInt() |
There was a problem hiding this comment.
v := p.Get("missing") can happen outside of these tests
static_provider_test.go
Outdated
| assert.False(ok) | ||
| }) | ||
|
|
||
| t.Run("float", func(t *testing.T) { |
There was a problem hiding this comment.
table-driven as opposed to sub-test would be much easier to write and maintain I think, but it's up to you
added 2 commits
June 28, 2017 10:02
ghost
changed the base branch from
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
- Coverage 95.38% 95.1% -0.28%
=========================================
Files 12 12
Lines 736 735 -1
=========================================
- Hits 702 699 -3
- Misses 21 22 +1
- Partials 13 14 +1
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self explanatory..