reduce method footprint

uber-go · May 17, 2017 · cb604a3 · cb604a3
1 parent 16581fc
commit cb604a3
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/internal/graph/graph.go b/internal/graph/graph.go
@@ -145,7 +145,7 @@ func (g *Graph) ValidateReturnTypes(ctype reflect.Type, checkCachedObjects bool)
 		objType := ctype.Out(i)
 		if _, ok := g.nodes[objType]; ok {
 			if checkCachedObjects {
-				if g.checkCachedObjects(objType) {
+				if obj, ok := g.nodes[objType].(*objNode); ok && obj.cached {
 					return errors.Wrapf(errRetNode, "ctor: %v, object type: %v", ctype, objType)
 				}
 			} else {
@@ -160,11 +160,6 @@ func (g *Graph) ValidateReturnTypes(ctype reflect.Type, checkCachedObjects bool)
 	return nil
 }
 
-func (g *Graph) checkCachedObjects(objType reflect.Type) bool {
-	obj, ok := g.nodes[objType].(*objNode)
-	return ok && obj.cached
-}
-
 // DFS and tracking if same node is visited twice
 func (g *Graph) recursiveDetectCycles(n graphNode, l []string) error {
 	for _, el := range l {