Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIG doesn't support channels and interfaces as first class citizens #88

Closed
ghost opened this issue Jun 4, 2017 · 2 comments
Closed

DIG doesn't support channels and interfaces as first class citizens #88

ghost opened this issue Jun 4, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Jun 4, 2017

It feels very unfair towards them:
https://github.com/uber-go/dig/blob/master/container.go#L113
@glibsm
Copy link
Collaborator

glibsm commented Jun 5, 2017

The link is now broken (post dev->master merge).
Does this issue still apply?

@ghost
Copy link
Author

ghost commented Jun 5, 2017

Looks like dig provides anything that is not a function: https://github.com/uber-go/dig/blob/master/dig.go#L76

@ghost ghost closed this as completed Jun 5, 2017
hbdf pushed a commit to hbdf/dig that referenced this issue Jul 14, 2022
@ascandella
Use default covermode count (uber-go#88)
57ed2ef 
Atomic is a bit aggressive and causing issues. Switching back to default
(count) so we can actually fix our data races.
hbdf pushed a commit to hbdf/dig that referenced this issue Jul 14, 2022
@glibsm
Slim down the main readme and point to appropriate ones (uber-go#88)
e240889
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glibsm