Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename service.Exit #320

Closed
bufdev opened this issue Feb 23, 2017 · 3 comments
Closed

Rename service.Exit #320

bufdev opened this issue Feb 23, 2017 · 3 comments

Comments

@bufdev
Copy link
Contributor

bufdev commented Feb 23, 2017

It's kind of an awkward name a little? Also is there duplication in the Reason and Error fields? If not, it would be nice to have some documentation. Note that in the Observer interface, you have OnShutdown(reason Exit) which is already confusing.

@bufdev
Copy link
Contributor Author

bufdev commented Mar 8, 2017

Any thoughts on this? @glibsm @sectioneight @madhuravi @alsamylkin @anuptalwalkar

@glibsm
Copy link
Collaborator

glibsm commented Mar 8, 2017

Agreed on string/error redundancy, we should drop the string.

Are we talking about renaming Exit struct to something else, or dropping it all together and just using one error field?

@HelloGrayson
Copy link
Contributor

Closing - this API doesn't exist in the modular branch, which will soon makes it way to the dev branch and beyond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants