Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack: Parse all functions #111

Merged
merged 8 commits into from
Oct 23, 2023
Merged

stack: Parse all functions #111

merged 8 commits into from
Oct 23, 2023

Commits on Oct 22, 2023

  1. stack: Parse all functions

    Adds support to the stack parser
    for reading the full list of functions
    for a stack trace.
    
    This includes the function that created the stack trace;
    it's the bottom of the stack.
    
    We don't maintain the order of the functions
    since that's not something we need at this time.
    The functions are all placed in a set.
    abhinav committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    b5b49ed View commit details
    Browse the repository at this point in the history
  2. Support Go 1.20 "created by" lines

    In Go 1.20, the "created by" lines
    do not include the "in goroutine" portion.
    abhinav committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    9e226f2 View commit details
    Browse the repository at this point in the history
  3. fix: Don't remove file paths from full traces

    `Full()` was accidentally dropping the file names from the full traces.
    abhinav committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    a649b8e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6173c18 View commit details
    Browse the repository at this point in the history
  5. doc: Explain empty line skip

    abhinav committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    af394ca View commit details
    Browse the repository at this point in the history
  6. stack: "created by" is not part of the stack

    The function tha created a goroutine
    should not be considered part of its stack.
    
    However, we can use that entry to mark the end of a stack trace.
    abhinav committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    7bdc274 View commit details
    Browse the repository at this point in the history
  7. test: Add real stack traces

    To verify the stacktrace parsing logic,
    generate real stack traces under the following conditions:
    
    - Go 1.21
    - Go 1.20 installed with gimme
    - Go 1.21 with tracebackancestors=10 set
    
    The test verifies that the parsed stack traces
    do not include functions that we did not expect to see
    in a goroutine's trace.
    abhinav committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    b4e7421 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Configuration menu
    Copy the full SHA
    5b4de07 View commit details
    Browse the repository at this point in the history