Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Str + Strs generic string helpers #1281

Merged
merged 2 commits into from
May 6, 2023
Merged

Introduce Str + Strs generic string helpers #1281

merged 2 commits into from
May 6, 2023

Commits on May 1, 2023

  1. Introduce Str + Strs generic string helpers 

    Implements uber-go#1275 by adding new `zapfield.Str` and `zapfield.Strs` types, which operate on generic string-like types and use the underlying `zap.String` and `zap.Strings` codepaths.

In uber-go#1275, the decision was to put these in a separate `zap/exp/zapfield` package and I didn't see an existing one, so I made a new `zapfield` package.
    @bcspragu
    bcspragu committed May 1, 2023
    Configuration menu
    Copy the full SHA
    974774f View commit details
    Browse the repository at this point in the history

  2. Fix lint + license check

    @bcspragu
    bcspragu committed May 1, 2023
    Configuration menu
    Copy the full SHA
    4f00950 View commit details
    Browse the repository at this point in the history