Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zapslog: fix all with slogtest, support inline group, ignore empty group. #1408

Merged
merged 9 commits into from
Feb 5, 2024
Merged

zapslog: fix all with slogtest, support inline group, ignore empty group. #1408

merged 9 commits into from
Feb 5, 2024

Commits on Feb 2, 2024

  1. zapslog: inline group if empty key uber-go#1402 

    Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
    @arukiidou
    arukiidou committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    e575540 View commit details
    Browse the repository at this point in the history

  2. zapslog: Ignore groups if empty Record uber-go#1401 

    Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
    @arukiidou
    arukiidou committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    28b05cb View commit details
    Browse the repository at this point in the history

  3. zapslog: Test with slogtest, fix all failures uber-go#1334 

    Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
    @arukiidou
    arukiidou committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f09e134 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. refactor: fixed inefficient []zapcore.Field insertion 

    Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
    @arukiidou
    arukiidou committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    104e04f View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. zapslog: add test coverage - WithGroup in WithGroup 

    Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
    @arukiidou
    arukiidou committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    baa935c View commit details
    Browse the repository at this point in the history

  2. zapslog: fix handler state management problems. 

    Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
    @arukiidou
    arukiidou committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    e10aad1 View commit details
    Browse the repository at this point in the history

  3. test nits: Adjust test names, remove unnecessary LoggerName checks 

    Logger name is already tested in WithName.
It doesn't need to be duplicated in every test.
    @abhinav
    abhinav committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    b2e66d2 View commit details
    Browse the repository at this point in the history

  4. fix: WithGroup.WithGroup.Info should not create an empty group 

    This requires holding onto a slice instead of a single string
to create the nested namespaces.

The slice is cloned on each WithGroup call.
We could probably do this more efficiently with an immutable tree of
references, but deferring that for now.

In the process, also make the addedNamespace business
append during the record.Attrs loop instead of after.
This is more efficient because we don't have to shift the slice over
afterwards.
    @abhinav
    abhinav committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    8ba79ba View commit details
    Browse the repository at this point in the history

  5. test: Run logger concurrently

    @abhinav
    abhinav committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    8466cda View commit details
    Browse the repository at this point in the history