-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog entry for v1.4.0 #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with cutting a release, but should we wait a week or so so we don't have to cut a new minor in a few days if we make progress on other changes (e.g., #425)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CHANGELOG.md
Outdated
## v1.4.0 (05 May 2017) | ||
|
||
This release adds the ability to customize the line endings used in zap's log | ||
output. It is fully backward-compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - Probably dont need to mention it's backwards-compatible, that's implied by the fact that 'dis is a minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to harp on that, since so many projects don't follow semver properly :)
Add a changelog entry for the 1.4.0 minor release.