Implementing grpclog.LoggerV2 compatible logger

[frankgreco]

Currently, go.uber.org/zap/zapgrpc.Logger only provides an implementation for grpclog.Logger. With the release of grpclog.LoggerV2, an updated implementation is needed so that go.uber.org/zap/zapgrpc.Logger implements both grpclog.Logger and grpclog.LoggerV2.

Fixes #534

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@f85c78b). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #538   +/-   ##
=========================================
  Coverage          ?   97.41%           
=========================================
  Files             ?       40           
  Lines             ?     2128           
  Branches          ?        0           
=========================================
  Hits              ?     2073           
  Misses            ?       47           
  Partials          ?        8

Impacted Files	Coverage Δ
zapgrpc/zapgrpc.go	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85c78b...d78f25e. Read the comment docs.

[prashantv]

is there a reason why we have to keep function pointers for each level, instead of just doing l.sugar.Info(..) etc?

[frankgreco]

@prashantv no reason. I was just trying to maintain the programming style that was previously present.

[bufdev]

@prashantv this is for the WithDebug function, which changes the zap function used for the Print functions.

[prashantv]

Ah, I see. In that case, aren't the only functions we need to do this for print and printf? The rest should just be normal function calls on the Logger.

[bufdev]

That would work too, either/or, I was just being consistent, especially “back in the day” before this PR when there were only a few functions :-)

[bufdev]

I'm sorry I missed this. The V implementation is incorrect. V does not correspond to log level, it can be things like 100. See https://godoc.org/github.com/golang/glog#Verbose and https://github.com/golang/glog/blob/master/glog.go#L999 for more details. This is why I didn't implement this originally as it was extra logic.

[bufdev]

Also see https://github.com/grpc/grpc-go/blob/master/grpclog/loggerv2.go.

It's not hard to implement, but it should be done in a thread-safe manner if you make V modifiable. glog does this.

[frankgreco]

@peter-edge good catch. I'll fix the implementation.

[bufdev]

@frankgreco any progress on this?

[kazegusuri]

I fixed the V implementation in my repo. Can I overtake this PR?

[frankgreco]

Yea! Sorry I haven’t had time to complete this. I’d be awesome if you could provide the V implementation!

[kazegusuri]

Thanks. I sent PR based on your commit, so please sign CLA.

[AlekSi]

@frankgreco please sign CLA. That should take only a few minutes.

[frankgreco]

@AlekSi

It seems that I have already signed the CLA.

You can verify from the username in that image and the username from my commits in this PR that they are the same.

Maybe we should get a repo admin involved?

[AlekSi]

Let's continue at #613.

[frankgreco]

@AlekSi I think I fixed it :) I did an interactive rebase an modified the author/email for this commit to an email that was on my account (I don't have access to verify the original email as I no longer work for that company). As you will see, the CLA has been signed in this PR. Now, the reason it isn't signed in #613 is because that is off of @kazegusuri branch which does not have my modified commit.

@kazegusuri can you update your branch so that you are using my modified commit? Then, we should all be good.

Sorry that this was such a mess :(

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ GRECO, FRANK
❌ frankgreco

---

GRECO, FRANK seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ash2k]

Would be great to get this merged! @frankgreco Perhaps you could squash all commits and use the right email to commit it?