Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apex/log benchmark #60

Merged
merged 2 commits into from
May 27, 2016
Merged

Add apex/log benchmark #60

merged 2 commits into from
May 27, 2016

Conversation

osamingo
Copy link
Contributor

Add apex/log benchmark.

BenchmarkApexLogAddingFields-8                    100000             16614 ns/op            3609 B/op         63 allocs/op
BenchmarkApexLogWithAccumulatedContext-8          100000             14201 ns/op            2385 B/op         48 allocs/op
BenchmarkApexLogWithoutFields-8                   500000              3048 ns/op             584 B/op         11 allocs/op

@coveralls
Copy link

coveralls commented May 26, 2016

Coverage Status

Coverage remained the same at 96.352% when pulling 02fb051 on osamingo:add-apex-log-benchmark into 07c03a1 on uber-go:master.

@akshayjshah
Copy link
Contributor

Nice - thanks for the contribution, @osamingo! Two things:

  1. Before we can merge this, you'll need to sign Uber's Contributor License Agreement. Please take a look and let me know if you have any questions.
  2. Please revert the changes to the README - since the apex/log benchmarks weren't run on the same machine as the others, they're not comparable. Once the rest of your code is merged, I'll run the new benchmarks on my machine and update the README.

@coveralls
Copy link

coveralls commented May 27, 2016

Coverage Status

Coverage remained the same at 96.352% when pulling 82a6090 on osamingo:add-apex-log-benchmark into 56e3723 on uber-go:master.

@coveralls
Copy link

coveralls commented May 27, 2016

Coverage Status

Coverage remained the same at 96.352% when pulling 6ef82ba on osamingo:add-apex-log-benchmark into 56e3723 on uber-go:master.

@osamingo
Copy link
Contributor Author

osamingo commented May 27, 2016

Before we can merge this, you'll need to sign Uber's Contributor License Agreement. Please take a look and let me know if you have any questions.

OK. I confirmed CLA.

Please revert the changes to the README - since the apex/log benchmarks weren't run on the same machine as the others, they're not comparable. Once the rest of your code is merged, I'll run the new benchmarks on my machine and update the README.

You’re right. I reverted it.

@akshayjshah
Copy link
Contributor

Awesome - thanks!

@akshayjshah akshayjshah merged commit 323dc68 into uber-go:master May 27, 2016
@osamingo osamingo deleted the add-apex-log-benchmark branch May 28, 2016 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants