license: allow github to detect MIT license #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves uber-go#731 github uses https://github.com/licensee/licensee to detect the license for the project. Because the project contains a file named "check_license.sh" it thinks this is a license file. It is unable to detect a license for that file and fails. Here is the run output: < ./bin/licensee detect ../zap/ License: NOASSERTION Matched files: LICENSE.txt, check_license.sh LICENSE.txt: Content hash: d64f3bb4282a97b37454b5bb96a8a264a3363dc3 Attribution: Copyright (c) 2016-2017 Uber Technologies, Inc. Confidence: 100.00% Matcher: Licensee::Matchers::Exact License: MIT check_license.sh: Content hash: 2ca67b08b61b91f2b3c67fe4581ee9e8dc9da2e8 License: NOASSERTION If you rename the file to checklicense.sh it won't think that it is a license file and will correctly advertise zap as a MIT project < ./bin/licensee detect ../zap/ License: MIT Matched files: LICENSE.txt LICENSE.txt: Content hash: d64f3bb4282a97b37454b5bb96a8a264a3363dc3 Attribution: Copyright (c) 2016-2017 Uber Technologies, Inc. Confidence: 100.00% Matcher: Licensee::Matchers::Exact License: MIT
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 40 40
Lines 2117 2117
=======================================
Hits 2063 2063
Misses 46 46
Partials 8 8Continue to review full report at Codecov.
|
prashantv
approved these changes
Sep 25, 2019
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
Resolves uber-go#731 github uses https://github.com/licensee/licensee to detect the license for the project. Because the project contains a file named "check_license.sh" it thinks this is a license file. It is unable to detect a license for that file and fails. Here is the run output: ``` < ./bin/licensee detect ../zap/ License: NOASSERTION Matched files: LICENSE.txt, check_license.sh LICENSE.txt: Content hash: d64f3bb4282a97b37454b5bb96a8a264a3363dc3 Attribution: Copyright (c) 2016-2017 Uber Technologies, Inc. Confidence: 100.00% Matcher: Licensee::Matchers::Exact License: MIT check_license.sh: Content hash: 2ca67b08b61b91f2b3c67fe4581ee9e8dc9da2e8 License: NOASSERTION ``` If you rename the file to checklicense.sh it won't think that it is a license file and will correctly advertise zap as a MIT project ``` < ./bin/licensee detect ../zap/ License: MIT Matched files: LICENSE.txt LICENSE.txt: Content hash: d64f3bb4282a97b37454b5bb96a8a264a3363dc3 Attribution: Copyright (c) 2016-2017 Uber Technologies, Inc. Confidence: 100.00% Matcher: Licensee::Matchers::Exact License: MIT ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #731
github uses https://github.com/licensee/licensee to detect
the license for the project. Because the project contains a file
named "check_license.sh" it thinks this is a license file. It is
unable to detect a license for that file and fails. Here is the
run output:
< ./bin/licensee detect ../zap/
License: NOASSERTION
Matched files: LICENSE.txt, check_license.sh
LICENSE.txt:
Content hash: d64f3bb4282a97b37454b5bb96a8a264a3363dc3
Attribution: Copyright (c) 2016-2017 Uber Technologies, Inc.
Confidence: 100.00%
Matcher: Licensee::Matchers::Exact
License: MIT
check_license.sh:
Content hash: 2ca67b08b61b91f2b3c67fe4581ee9e8dc9da2e8
License: NOASSERTION
If you rename the file to checklicense.sh it won't think that it is a
license file and will correctly advertise zap as a MIT project
< ./bin/licensee detect ../zap/
License: MIT
Matched files: LICENSE.txt
LICENSE.txt:
Content hash: d64f3bb4282a97b37454b5bb96a8a264a3363dc3
Attribution: Copyright (c) 2016-2017 Uber Technologies, Inc.
Confidence: 100.00%
Matcher: Licensee::Matchers::Exact
License: MIT