Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop library level constraints on tools #795

Merged
merged 2 commits into from Mar 5, 2020
Merged

Drop library level constraints on tools #795

merged 2 commits into from Mar 5, 2020

Conversation

abhinav
Copy link
Contributor

@abhinav abhinav commented Mar 4, 2020

This renames tools.go to tools_test.go so that tool/development
dependencies are not considered transitive dependencies by go mod.

(We upgrade multierr and atomic to the most recent releases with a similar
fix.)

While at it, this also adds staticcheck to lint Zap.

Refs T5279939

abhinav added 2 commits Mar 4, 2020
This renames tools.go to tools_test.go so that tool/development
dependencies are not considered transitive dependencies by `go mod`.

(We upgrade multierr and atomic to the most recent releases with a
similar fix.)

Refs T5279939
This adds staticcheck as a linter to Zap and fixes issues found by it.
Specifically, it found a few unused unexported types and functions.
@abhinav abhinav requested a review from prashantv Mar 4, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 4, 2020

Codecov Report

Merging #795 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          43       43           
  Lines        2310     2310           
=======================================
  Hits         2271     2271           
  Misses         32       32           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c14fe6...dd95ca6. Read the comment docs.

@abhinav abhinav merged commit 9646482 into master Mar 5, 2020
5 checks passed
@abhinav abhinav deleted the abg/no-tool-dep branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants