Update Stringer panic check to look like stdlib #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no behaviour changes, but there are a couple of refactorings: * Name the named return error `retErr`, and use explicit return values. The only purpose of the named return is for the panic handling. * Make the panic handling look more similar to the standard library and add a reference to the stdlib code in fmt that does the same checks.
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
==========================================
- Coverage 98.36% 98.36% -0.01%
==========================================
Files 43 43
Lines 2382 2381 -1
==========================================
- Hits 2343 2342 -1
Misses 32 32
Partials 7 7
Continue to review full report at Codecov.
|
abhinav
approved these changes
Aug 28, 2020
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
There's no behaviour changes, but there are a couple of refactorings: * Name the named return error `retErr`, and use explicit return values. The only purpose of the named return is for the panic handling. * Make the panic handling look more similar to the standard library and add a reference to the stdlib code in fmt that does the same checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no behaviour changes, but there are a couple of refactorings:
retErr, and use explicit returnvalues. The only purpose of the named return is for the panic
handling.
and add a reference to the stdlib code in fmt that does the
same checks.
This is a follow-up to #854