Encode errors under different keys #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force-pushed after resolving merge conflict. |
|
lgtm |
Currently, we don't handle encoding errors in a consistent way - `AddObject` serializes the error into the log message, but `AddMarshaler` logs the message to standard out. Even though very few portions of the code can fail at runtime, we end up checking and managing errors all over the place. This PR allows the encoder to return an error for `AddObject` and `AddMarshaler`, which are the only two methods that can fail. However, the field handles that error by serializing it under a different key (errors for the key `foo` are serialized under `fooError`). This should make our APIs less cumbersome and our error handling more consistent. It fixes #43.
|
Resolved more merge conflicts, force-pushed. Will merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before opening your pull request, please make sure that you've:
make test); and finally,make lint).Currently, we don't handle encoding errors in a consistent way -
AddObjectserializes the error into the log message, butAddMarshalerlogs the message to standard out. Even though very few portions of the code can fail at runtime, we end up checking and managing errors all over the place.This PR allows the encoder to return an error for
AddObjectandAddMarshaler, which are the only two methods that can fail. However, the field handles that error by serializing it under a different key(errors for the key
fooare serialized underfooError).This should make our APIs less cumbersome and our error handling more consistent. It fixes #43.