Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml.v2 version bump to fix CVE-2019-11254 #936

Merged
merged 1 commit into from May 18, 2021

Conversation

@jimmystewpot
Copy link
Contributor

@jimmystewpot jimmystewpot commented Apr 16, 2021

Hello,

The included version of gopkg.in/yaml.v2 (v2.2.2) has a reported vulnerability of CVE-2019-11254. To resolve the vulnerability the version has been upgraded to v2.2.8.

The testify libraries have also been bumped from 1.4.0 to 1.7.0 to avoid the same vulnerability.

As per the contributors document the make test and make lint targets have both successfully completed on Go version 1.13. The tests will fail on Go 1.16 due to the following bug bug.

- gopkg.in/yaml.v2 v2.2.2 -> v.2.2.8 CVE-2019-11254
@codecov
Copy link

@codecov codecov bot commented Apr 16, 2021

Codecov Report

Merging #936 (65cac8f) into master (c23abee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          44       44           
  Lines        1974     1974           
=======================================
  Hits         1940     1940           
  Misses         27       27           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23abee...65cac8f. Read the comment docs.

@jimmystewpot
Copy link
Contributor Author

@jimmystewpot jimmystewpot commented May 11, 2021

Is there something missing from this PR which is blocking a review?

Copy link
Contributor

@abhinav abhinav left a comment

Apologies for the delay. This looks fine. Thanks!

@abhinav abhinav merged commit 8b883c6 into uber-go:master May 18, 2021
4 checks passed
4 checks passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
@codecov
codecov/patch Coverage not affected when comparing c23abee...65cac8f
Details
@codecov
codecov/project 98.27% (target 95.00%)
Details
license/cla Contributor License Agreement is signed.
Details
abhinav added a commit that referenced this pull request May 25, 2021
- gopkg.in/yaml.v2 v2.2.2 -> v.2.2.8 CVE-2019-11254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants