Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gltf: support KHR_materials_unlit extension #445

Merged
merged 4 commits into from
Sep 26, 2019
Merged

gltf: support KHR_materials_unlit extension #445

merged 4 commits into from
Sep 26, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Sep 26, 2019

@tsherif @jianhuang01 FYI - photogrammetry tiles are already lit and lighting needs to be disable for these tiles.

materials can now have an unlit: true field

@ibgreen
Copy link
Collaborator Author

ibgreen commented Sep 26, 2019

See visgl/deck.gl#3705

@coveralls
Copy link

coveralls commented Sep 26, 2019 •
edited
Loading

Coverage Status

Coverage increased (+4.2%) to 60.037% when pulling f0a8032 on ib/gltf-unlit-extension into 560540e on master.

@ibgreen ibgreen merged commit 1bb1fe2 into master Sep 26, 2019
@ibgreen ibgreen deleted the ib/gltf-unlit-extension branch September 26, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibgreen @coveralls @xintongxia