Add a more detailed type definition for WebMercatorViewport.getLocationAtPoint()
#201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type definition for
WebMercatorViewport.getLocationAtPoint()
currently uses implicit any typing forlngLat
andpos
. This can cause TypeScript build errors ifnoImplicitAny
is enabled andskipLibCheck
is disabled:This PR is a one-line change to add types for these arguments. The type signature for the function now matches the non-legacy
WebMercatorViewport.getMapCenterByLngLatPosition()
method (visible a few lines up in the diff). The legacy function simply calls and returns the non-legacy method with the same arguments, so these should have the same type signature: