Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ClassesWithScope to TypesWithScope #300

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Rename ClassesWithScope to TypesWithScope #300

merged 2 commits into from
Dec 3, 2018

Conversation

ShaishavGandhi
Copy link
Collaborator

Took this opportunity to move to camelCase for the properties file. The Gradle docs have properties with camelCase. I'm also fine with keeping it TypesWithScope just for consistency. Thoughts @hzsweers ?

Fixes #297

ZacSweers
ZacSweers approved these changes Dec 3, 2018
View reviewed changes
Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camel case is fine with me there. Can you update the error prone wiki with this as well?

@ShaishavGandhi ShaishavGandhi merged commit 76db7cc into master Dec 3, 2018
@ShaishavGandhi ShaishavGandhi deleted the sg/types-with-scope branch December 3, 2018 04:25
@ZacSweers ZacSweers added this to the 1.1.0 milestone Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacSweers ZacSweers ZacSweers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaishavGandhi @ZacSweers